Felix Lange

Results 442 comments of Felix Lange

The 'ethclient' RPC simulation now works again (as of #418). We could still add some more tests to it, but the hard part is done. @tkstanczak The tests found two...

This is improved in #348. The datatable filters etc. are not tracked, but basic navigation and linking works. Anything beyond the changes in #348 will be a lot of work...

I have figured this out now. The issue happens when hive is run before Docker has brought up the docker0 interface for the first time. There is no good workaround....

Hive captures client logs by attaching to the container via Docker API. I think docker does not / cannot apply this buffering to the attached connection. I will look into...

Yes, it looks like the issue is that hive does not use the equivalent of 'docker logs' to get container logs. Instead, we attach to the container before it starts...

I think this issue should be closed. `in-memory-stream` is explicitly a binary stream with no support for characters. To get characters, a flexi-stream needs to be used on top of...

Hi. I understand that you are looking at this API from an efficiency perspective. We are more focused on correctness with this API. `types.Transaction` and `types.Block` are meant to be...

I feel slightly unsure to remove this feature. If we remove it, we absolutely have to keep the warning at least.

This log message kind of sucks. I think we should add the policy where log messages intended for humans should not be phrased in this 'machine event' style. How about:...

Yes I mean changing the log message, replacing the `Ignoring deprecated node list...`