fisker Cheung

Results 1279 comments of fisker Cheung

On second thought, it can be a bad idea. Even if we found `{NODE_PATH}/prettier-plugin-foo` directory, we still can't know how to `import()` it, since `require()` accepts directory, but `import()` don't....

Node.js suggest use symlinks. > NODE_PATH is not part of resolving import specifiers. Please use symlinks if this behavior is desired. https://nodejs.org/dist/latest-v20.x/docs/api/esm.html#no-node_path

Maybe we should fix this too. **Prettier pr-15035** [Playground link](https://deploy-preview-15035--prettier.netlify.app/playground/#N4Igxg9gdgLgprEAuEBbAngMQK5TDAS2gApiBnCVOAQQCcBzbK2ASgAIBeAPjYBsIBgocJGjRUejjyFoAYQCGvXgH4AdMRYsAOlAxT8RKKQpU6jZjHbc+Y23bET9MqAqUaWIADQgIAB2dkyKDytLQQAO4ACiEIgSiK4fLogd4ARrTyYADWcDAAyvJUADIEUHDIAGaKZHBpGdm5eb6ZpfTIMLTYtSA1qATtnd1krbxwAIrYEPCV1d0AVmQAHnkj45PTSFW8Nd4AjutwkWG+cSDyZAC0ZXAAJrdeIB3yBLytspSo8shnSg-DEqNqDAOgRUth4JE4LQSmUZttugALGCoXgAdQRBHgZGaYDgeVimIIADdMehvmAyCkQESugBJKB3WB5MC0Aj+agMvIwdCjOE7EC+MI1VEZXzfQVwGq0InlbylKUwI7yeifPndZq0KXfTIQWhQB6C0owVEEG4wBHIAAcAAZvLQ4PsCPalSqvptZt4YPJUiazRakAAmbzYGoAFW9cS2-LgqFStzuNyK8gk2GVcEwus+wNa2vBEBAAF8C0A) ```sh --parser acorn ``` **Input:** ```jsx myFunction((someArgument) => looooooooooooooooooooooooooooooooooongFunctionCall?.()) myFunction((someArgument) => looooooooooooooooooooooooooooooooooongFunctionCall()) ``` **Output:** ```jsx myFunction( (someArgument) => looooooooooooooooooooooooooooooooooongFunctionCall?.(), );...

> it breaks the code Have you test yourself? > it's introducing bugs What kind of bug? Will it make your code result differently?

For the ones may interest, [1](https://stackoverflow.com/questions/70102722/whats-the-precedence-of-typescript-operators) [2](https://github.com/microsoft/TypeScript/issues/19707)

@liuxingbaoyu It seems [v2.8.8 works the same way](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAzArlMMCW0AEARujgDYAmAcgIYC2cAzgA7VhwBKccAHkxAE4wAFAEp8wADpR8+fnBjp+0oVJkzIUBjGqxOPPoIaq1MgPz54tJqWrwAdFttx6sAAbGTMgPKEAVnGw7AGs4AE8GIUoAQQBZAFEAZQAFKIBhOJE7VAE41gALIQwsXGghENCxSWlPExxUfDKw-ABeVvwJEHI4VGp0UhgO-AAfIfxylraOgH0pxhiIcj64DrE5BSUAbg8a-AA1OPYASQAxAE0p6PipgBlDhIAVLeqd-DqG8ZxpOIANJK92e4JfAAMmB+B+fwBCQA2uUALoTZr4S6JFLpWFhOGreSKKBPbY1CH-QEY0IIpEo5JpOKkuFPF4AXxE9M8riQ+AA9Bz8FFSAwIPgGEEcEx8NRSHJqORQmKGAwcABzKBwchET7kT4KhiveowPJNahyQUwfg4bCkGVwACO6HFBLUXIsAsIcEFEHoAHc8rZ8LQBK7mAEALSQKykHA6GD4L0IMX4VBkV3e7W0Pq4azLZ6eR1QOiMFhsWRwIP6AQwbV6n0eiB9VVgXoMV3UNVQDVQBVOoiu0uCFX2mSO1P9EWkV24egMOz4AASEA9cAAbnB+AAaX1pkeuwjqzXaiC6-WCvP4XP0CzegZZkyOntRvUB49MU20HC4Jf4Bfi9BNo3y0ewC1BWFJgmD7K8HW5IR70FUCwCLG0cDkbUdHaEA6G3BV0BrbVt1bXdBjgQ1AOXfgBHwfU5EyfsLGcawnAcbRLAQGB3HA7w-ACGBgjCCJKTRDIshyfJCkwbA8CgRoKnEaiZDeSTEVQroejTQYRjGJpWiRaZZgYeZFlHFYi3WPEZL2A4TnOFEbjuR5TLkj4vl+YkgVBcEnKhWkFL46laWxYz8TYtQfH8QIlM+OAklI0DBFCIQiShNdyjXKoXhMBB0HofhqEIUd2RNb8V1MmQFXkdkijE0pKiKtQ1lxZFYlRHz4RZVL8AZQrApkJkWs8brtlYmQRCEFK1G89J2VPfNWDgDqTHiwF2XobRyFsag7FvGh6FmtR9iOM4Lga6yHkW+QpVW9beDLTa4GuHAtGu+1zEsOj4AG1qdQaeaEiO+47HVHgvFQSSRD83EepqVxhrcyFAR+k7lvOja81u+7jyZe0Jr6Uhtr6qAGSkKQQBXEAICYEpNGQUBDVIj0kkNBAGGQNDSA9ahwiJkBCCysAQhgBJkfC5Aej5GbOe53mEgLTVkHy0XnBdcgunIa4dEw6gSuOARaFsXB2yZ3oYAgDm8hgWhSAAdTyV8prYBIGdfHAF1fUImbAOUOc+RtBEi9XtaF8VG2J3wGG4BJNVHABFLD4H9kXiZYfgvaZwhsrgUgOafT4YHNnByD1ZAAA4AAZ49IxtzaypgmafRhlyXDmbQgeBItJxmUGoBgg2VFUVQ5uQELkH2FT9pBhcDkBGxfGX+AKifw7gKIYBNHBiGb5dbuVWPx-ldtI+juAt9F7RCBzvO8mQAAmYmTWoMhNVSd0R5ARgAFYOfQRt7mytux9Fhdv0OK2ZiCQwCmjJlEVsCQYChFHIfBkDIgA). I agree it's not expected, just not regression.

Updated to use stable verison of playground.

We don't consider compatibility with ESLint rules.