fisker Cheung

Results 1279 comments of fisker Cheung

I've already tried to implement this the other day, my experience on using private fields, I really need [proposal-destructuring-private](https://github.com/tc39/proposal-destructuring-private) ```js const {a, b, c, d} = this const e =...

I don't think this rule should limited to Literals, ```js const set = new Set([ undefined, undefined, foo, foo, foo.bar, foo.bar, ]) ``` This is obviously duplicated, I think we...

What do you think about live lint result like this? https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-contradiction-with-assertion.html

> "What if" the Number constructor changed? It's never going to happen. > The number one guiding principle, which the committee is unbending on, is “Don’t Break the Web”.

If someone want implement this, I prefer update this function https://github.com/sindresorhus/eslint-plugin-unicorn/blob/dc7f79b0e0a87d7dc009905c9dc76719d9f5a3ff/rules/utils/boolean.js#L29 So other rules can apply the same logic

Would you like to send a PR add `CB` to this list? https://github.com/sindresorhus/eslint-plugin-unicorn/blob/0034e6938a95600288c44a10963506c7bd0cb464/rules/no-array-for-each.js#L373-L379

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/59218e3cd653fdf9ad7e7f5d2666e8c2fa775601/rules/utils/is-node-matches.js#L46 > Should it also be made so that this list is configurable by the user via an option? Fine, we can use this https://github.com/sindresorhus/eslint-plugin-unicorn/blob/59218e3cd653fdf9ad7e7f5d2666e8c2fa775601/rules/utils/is-node-matches.js#L46

The proposal has updated, see https://github.com/tc39/proposal-change-array-by-copy/commit/752e576db3d55e9d1d80a97df1f1e54c26ffbd7f - `withReversed` -> `toReversed` - `withSorted` -> `toSorted` - `withSpliced` -> `toSpliced` - `withAt` -> `with`

[Change Array by Copy to Stage 3 per 2022.03.30 TC39](https://github.com/tc39/proposals/pull/406#)

You may misunderstood, the braces creates a new scope, when there are variable declare, braces are required. Correct me if I'm wrong.