fisker Cheung

icon indicating a website link https://fiskercheung.com/ icon indicating an email [email protected]

icon company @d0d0dotcom icon location China icon location Husband, father, coder.

Results 1279 comments of fisker Cheung

Rule proposal: `no-typeof-undefined`

I don't think `no-undef` is safe, for example, when you write code for browser, the following won't report, because `AbortController` is considered "defined" as globals. ```js if (AbortController !== undefined)...

Rule proposal: `no-typeof-undefined`

I'm going to work on this. And I'm going to add an option to ignore global variables.

Update prettier to v3

1. Remove embed, if you are not going to use it. 2. Remove 2nd parameter in `parse` (optional, the 2nd and the 3rd are actually all `options` 😄 ) 3....

Update prettier to v3

parsers all async. (All most, but all should be `await`ed)

Update prettier to v3

I didn't see you call parse. What's wrong?

Update prettier to v3

Try add ```js trailingComma: 'es5' ``` https://github.com/prettier/plugin-pug/blob/2bc5392fd35ae69f39d5311110aa168d2c1374a2/src/printer.ts#L464

Update prettier to v3

And here https://github.com/prettier/plugin-pug/blob/2bc5392fd35ae69f39d5311110aa168d2c1374a2/src/printer.ts#L650

Update prettier to v3

Sorry, wrong comment.

Update prettier to v3

Ah, I forgot it's expected https://github.com/prettier/prettier/pull/13100

Update prettier to v3

Anyway, do you aware this https://github.com/prettier/prettier/blob/f2244bdc8621c0a001e3717f595bc8fd8653cce7/src/language-html/embed.js#L157? Not sure how we handle here.