fisker Cheung
fisker Cheung
4, my idea is to consider `unicorn unicorn unicorn ` as 3 repetitions, then compare string after it, we can result `unicorn` be the repeated string(4), and space be the...
But ```js " " ``` already unreadable. We need a good algorithm here.
Make sense to me 👍 .
Didn't see https://github.com/xojs/xo/commit/dddc991a9e1a96993f6455bfe166dc15c2b80d7e#r67879026, feel free to close if you don't want to enable it.
You are right. For people like me may don't care about `no-shadow`, maybe we can put this check behind an option.
https://github.com/xojs/xo/blob/7da6311abcd069bea561a9be0f9b7aa220784a34/index.js#L105 Wrong `options.isQuiet`, should be the outer `options`.
Another question, currently ```diff - const foo = (bar, baz) => bar.x === baz.x; + const foo = ({x}, baz) => x === baz.x; ``` This is a little a...
Should also check `.findLastIndex() > -1` .
> It can check that spread isn't used when there's only a single property. It can be making a shallow copy. In object spread, it can also ensuring object type....
@rightaway I'm going to skip check spreading single UNKNOWN object, if you still want it please open a separate issue.