fisker Cheung

Results 1279 comments of fisker Cheung

There are lots of other [`UnaryOperator`s](https://github.com/estree/estree/blob/master/es5.md#unaryoperator), if you mean to include them all, add more tests.

> Should Identifier also have a new line? Maybe we can try the opposite, instead of break before `!fooooooooo`, but remove new line before `foo == null`? There are too...

> Is there a problem if I change it so that all patterns have a new line? I'm not familiar with this part, I don't know, sorry.

I ran this change over some codebase, some case doesn't look good. mostly the variable declaration ```diff - const unwrappedInit = hasUnaryPrefix(init, '-') - ? init.argument - : init; +...

I'm running this over other codebases, let's see how this effect them https://github.com/prettier/prettier-regression-testing/issues/130#issuecomment-1021795787

The new output looks better to me. And changes in #12087 #10158 seems not effected 👍. Anyway, we need more review.

Anyone considered break line both before and after? ```js const isEventTarget = value != null && typeof value.addEventListener === "function" && typeof value.removeEventListener === "function" && typeof value.dispatchEvent === "function"...

Not an issue in core, transferred to prettier-vscode repo.