fisker Cheung

Results 1275 comments of fisker Cheung

Blocked by https://github.com/typescript-eslint/typescript-eslint/issues/11762

I'm running tests for `eslint-plugin-unicorn` rules, to prevent rules from introducing syntax errors in the fix logic. https://github.com/sindresorhus/eslint-plugin-unicorn/tree/main/test/integration There are lots of files in some of our testing [repos](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/902538609b431dbbcf400fe41f45bd7b952079ca/test/integration/projects.js#L28), and...

> What is your definition of "fatal error"? https://github.com/eslint/eslint/blob/0f5a94a84beee19f376025c74f703f275d52c94b/lib/linter/file-report.js#L584 > Currently, ESLint considers only parsing errors to be fatal errors. That's what we want.

> Wouldn't it make more sense to create RuleTester tests to verify that your rule doesn't have bugs? Is `RuleTester` mean to test one single rule? Am I wrong? I...

About > the "(unchanged)" people are asking to remove it, I already mark this as accepted. https://github.com/prettier/prettier/issues/15480

`"0ms"` because we can't snapshot the real time , It's mocked.

Ha, this is the first issue about `switch (constant)`, and someone don't like [my little secret](https://x.com/fisker/status/1824522204765434171), much longer than I expected to see this issue. When I implemented this rule,...

I think it can be useful in some cases, eg ```js switch (true) { case node instanceof Foo: // ... case node instanceof Bar: // ... } ``` Let's keep...

~[no-useless-escape](https://eslint.org/docs/latest/rules/no-useless-escape) not catching this, but the `\` in `` `$\{a}` `` is not useless, the second `\` in `` `\$\{a}` `` is.~ [no-useless-escape](https://eslint.org/docs/latest/rules/no-useless-escape) not catching this, since they are not...

I think this can be useful, but I have two cases I don't want the variable inside the function: 1. A constant, that's a big array, object, map, set, or...