fisker Cheung

Results 1275 comments of fisker Cheung

I think `eslint-disable` make sense for this case.

I'm fine to add this option.

The value `-1` acts like a constant meaning `non-exists`, compare it with `===`/`!==` instead of treating it as a number makes more sense to me.

I don't think the file size matters. Can you try to delete some code and find which part cause the problem?

Compare the first format and the second format, should be able to find the problem.

First case **Prettier 3.6.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAzCAnAFAGzjAbRwBooBdCVAAgHkAjAKzjBgDoEYMBLOAZyzgBKQcDyEMxAJLEAhmQC8UYgV7EICjK14AHHFxhYA9FUODiAE3n0mLVjN68uAcyhZgAW3wALCOaSqAVwwcJAgAXylBAG5UAGZWL3ssGEEAH1S4rXxk0jgAdyoAWRltM0ynbJSsgxJgXkhtOCQYYk8YH3MAORlPJBIEc20ILlgAEThUGQCcGF4kcwtmTBkYLmg5mTDBMJBiEAhtVfXkUBkMDAg8gAUzhF5kEBkcPJkAT3u9ugwZMABrfAAyj04AAZEZwZCTHC8OB7CCMZgwADq320D20GD4cAwADcIZ9vn9AdofiMnMhOAFYSAYe4uBSMFS9nAAB6NbieWBPGjslaYK4QRxHKAPAa7ECs9lcTkwJ4AFWxUDOPHuSChML2jigTjwAEUAhB4JCnhqQAxeCyAWS9QajWqTdSAI62uBXC7aVWPXgAWigcDg5gD4s4Mi4em1AGEIO53DIHk8cOKtTq4ABBGCcLh0ALwK7YsF+43Q6leGDuHBIrz6PgksBwAF3fRcHH6V4PMAOcU4qmSKCB2AAsDcQ6pvsAmCvPBF00YwVwFEldGYmG4-EgEYrmBumROWPT6kkjArh50GR0OCJvYYkbIrjmdrIAAcAAY9pjnVxMdvd3H7cW9rKdBIneD5IAATHsAQwnKZ6quq1JwO457mIG5ggjI2oBDucAAGKYLGGZkvGOYQCAYRhEAA) ```sh --parser babel ``` **Input:** ```jsx for(let[l,n]of Object.entries(e)){let[r,I,a]=n,[s,o]=r.split(/ /),d=Object.assign({method:s,url:o},I);f3.has(t)||f3.set(t,new Map),f3.get(t).set(l,{scope:t,methodName:l,endpointDefaults:d,decorations:a})} ``` **Output:** ```jsx for (let [l, n] of Object.entries(e)) { let [r, I, a]...

Second case **Prettier 3.6.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAnOMCuqrFRAGziQB0QBDAZ0oEtKZzYyAaSWBGJGAOhgkID6YcgQKVuAMxoF4qABQBBBQEpuAW3IAHOXAC8APjnAYAT03EyfQZkpwWNACZI43R8yjk1xFxMxQwMDTQ3B5ezDRQmpicAFIAygDyAHLcmuSotjqSfgFBUNzpAOaYXrCUygC+ypUA3CDMIBCagdCUyKDp+ADuAArpCG0oIl3kJm0NAEao5GAA1hhxnnAAMhFwyBIitg0QEwBWcAEA6tOayCCa6LaoAG7rk9NzC2lgEYXIMKiYcA22ajQfL4-EBwAAe5lQNFKDAICQh5D4qB6EFoLSg5wQDnqIPBcEh0JEABU8R5IXBBpsxMDaFBCkQAIqYCDwDZbYF7SiguJvBlMllISnbEAARz5cB6+E0gwolAAtFA4HAHErsZ9yNI3gBhCBqDTnEQEbE0ulwBQwT40CbRcV41YK1lUhoACxgagIRydNHglBecDiAy9NBuXpM5zA1GxN2+AEkoMrYHEwJDmgo43FTEQHULLii4CctOdLuS8XdsRFrjAJeRCnqBWyGmkMnjzhNyBM4IaG5DYEdHDAncgABwABga6FFNHQVZr5CzwIYE17Dn7yAATA0bHBCW2KfWQWp2w5lQ5loxitW4AAxCCoDTmt766IQEAVCpAA) ```sh --parser babel ``` **Input:** ```jsx return{role:"assistant",content:t.tool_calls.filter(AA).map(e=>({type:"tool_use",id:e.id,name:e.function.name,input:JSON.parse(e.function.arguments)}))}; ``` **Output:** ```jsx return { role: "assistant", content: t.tool_calls .filter(AA) .map((e) => ({ type: "tool_use", id: e.id,...

Third **Prettier 3.6.2** [Playground link](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEAzArlMMCW0AEAhgBQCUwAOlAE5wzrVT4wB0ADoTABbECSp7CAGcYxAPIAjAFZxsLQkKE4A5lHHTZrBUtXFgAXwA0AIWXEANqVKHgkWAhgAVAJ5s4SCiEJs25nGE48KAB6KSFoT0MuOEIAEzhqISRJGTltFTVgQjAwODYYDy8fPwDcaFDwqE8jYmoAXnMWWgBHdDgRMXygoVI6vqh0c3MAH2H6voA3CBxY-AAGAH4pmfmkahZouISewwkIWOckABIAa1E4Un0rKn0qEEMQCC7oIWRQQmpqCAB3AAUPhCvFCEczfQjOV4PCTUbInOgAZUIAFs4AAZHBQODIVAgoRwB4QDTYADqMLYyBAbFoeOoEyxUJhYDhMHhHDAGOUyBg1DaDzxSJwXJ5+JAcAAHm5qDgUbAQZ0EpwINRfsIcGUoBSELF7qKJQlpQ4QY4ElAPjh2tjcSKlFBlOY4ABFdAQeCW8x4h5hMXwjn2p0urFIHHukWtAO-L5sIFeIQAWkxcHi2oe3MIOD8toAwhAkUjCBSQeYdTa7XAAIIwbk4CToeC-BLozFuj0gLgwJHmYlcNXtNlweGAtU4CZq5wUsCKHUTNq8KDxWDwsBS-JlufwmDOe3NkVU4RwUneClU9oJOk6jE0mARwjKPPbh4cRIJCkSQgSOBFh9S2DEmbcZAABxzA8LToDgtDXre+ZBlaKZvr+sT-kgABMDzoHijhvkCwYtnASLvrESaooQtroDecAAGJKnmlYcgWtYQCA+j6EAA) ```sh --parser babel ``` **Input:** ```jsx function a(){ return t.path(I).post(Object.assign(Object.assign({},Bg(l)),{contentType:"application/json",headers:Object.assign({accept:"application/json"},(r=l.requestOptions)===null||r===void 0?void 0:r.headers),body:$kt(e)})) } ``` **Output:** ```jsx function a() { return t .path(I) .post( Object.assign(Object.assign({}, Bg(l)),...

There are still more, but we can fix one by one.

This can also apply to `toSpliced`, ``` // ❌ array.toSpliced(10, 1, element); // ✅ array.with(10, element); ``` But we can focus on `.splice` first.