fisker Cheung

Results 1275 comments of fisker Cheung

Still broken, but I'm going to pretend that I don't know **Prettier pr-18460** [Playground link](https://deploy-preview-18460--prettier.netlify.app/playground/#N4Igxg9gdgLgprEAucBnVADAZhCACJAEmACMBDAJwF89gqMQAaECABxgEtpVlRKKIAdwAKlBDxRkANoLIBPHsxIUyYANZwYAZTIBbOABkOUOMizTUcZhBIArOGBgB1Fa2QhWFOJYoA3U0oq6pparKrGAObIMBQArlYglroc0XEJcAAerHAUHPqw0gDy2SowEBTCEKgcnNDuCAAmTCCZJXkIMNIAKjlQlBzeZhYJ1VARUnAAirEQ8ENSlsy2qBlakRPTs6ZI5gsJAI4z8MICrBIgZKgAtCZwDXfNMWQcUpEAwhC6umTu0lLNo3GcAAgjAYhwSLFjjkjCZ5osQAALGC6KRORE1bxhMBwLTiGocXw1OTuMDoZq+eIASSg91gWjAuXYwNpWhgcgm8ISniqcBcZDcKE83hy-majUKWFh2xAUiwzWMPhgJzIEW+XOYYQoPnc5BIcH+mtysCcHAaMERyAAHAAGZheQ4cLwqtU-HbDZidEim82WpAAJmYsUsXTIJAkuwRcF0+oa9waBjIY1iqrgADFyt8wZFflCICAqFQgA) ```sh --parser babel ``` **Input:** ```jsx css`foo :${bar} {}` ``` **Output:** ```jsx css` foo:${bar} {...

Nah, not worth the effort. Let's wait for someone actually write it this way.

I'm sorry that I didn't notice that this repo is already in a great organization. Feel free to close if you don't want to do the transferring.

Can you explain why `delete object.property` is bad? Sometimes, you can't declare a new variable, you have to mutate the original object. I think it's useful.

I think the bug can be fixed by removing the initial value of `shouldSetCache` ```diff - let shouldSetCache = !isDifferent; + let shouldSetCache = false; ``` Will it work? Also,...

Hello @kovsu , sorry for the long delay. Do you know why we need `removeFormatResultsCache`? Shouldn't the file hash mismatch on the second run? For example: If I run `prettier...

Actually, these two are different, the first one will result all ``s even it's not in ``. There are difference between `document.querySelectorAll("select").querySelectorAll("option")` and `document.querySelectorAll("select").querySelectorAll(":scope option")`

Normally, we start using new syntax, methods after our dev version supports it. https://github.com/prettier/prettier/blob/3c2b0b135a26976509f20666962c930fea8a2856/package.json#L36 The compatibility issue will be solved in the build scripts. I guess it's a little bit...

#1152, maybe we should only fix if it's known RegExp?

Unknown directives not supported anymore https://github.com/angular/angular/pull/62644