Yuxuan 'fishy' Wang
Yuxuan 'fishy' Wang
this seems to be fixed in gazelle `v0.38.0`. now that gazelle itself works to update the build files, but I'm hitting some issues with proto dependencies on the third party...
Thinking about this issue more, I start to suspect that it was caused by something wrongly cached by bazel. When I could reproduce it, I was trying to migrate a...
~~one of my colleague somehow reproduced a very similar issue on our CI system, the error is the "opposite" that it complains about unable to find `io_bazel_rules_go`:~~ ``` Unable to...
~NOTE: this fixes a bug in the new feature added to the 0.21.0 release, so it should ideally be part of the 0.21.0 release.~ changing this PR to target master...
also cc @dcelasun
> Metrics are their own middleware, not relying on the span framework right? correct
> 👍 > > > This change could be jarring for service owners to have tracing unceremoniously dropped and need to scramble to understand why their deployments are suddenly missing...
@trevorriles A few things I want to emphasize here (some are moved from the slack thread): 1. The middlewares I removed from being default all call `AsSpan`. They call `AsSpan`...
> Should the `InjectServerSpan` logic already be short circuited by this code when using the transition library, without the need to remove it entirely? > > https://github.com/reddit/baseplate.go/blob/c7e065837fc5906607a660629fb6f9cb08e3247d/thriftbp/server_middlewares.go#L149-L151 > > Removing...
@trevorriles ok I created https://github.com/reddit/baseplate.go/pull/665 to solve this problem differently.