Yuxuan 'fishy' Wang
Yuxuan 'fishy' Wang
I hit this issue the other day when I try to use bazel to run unit tests while offline, and I have to temporarily create a `.bazelversion` file to make...
Hi, Thanks for the great write-up on Google Doc! I was trying to follow it to implement the 1.5 API today, and got pretty far, but encountered two issues: 1....
^ Oh I figured it out. There are a few things required for upload to work missed from the Google Doc. Things I'm 100% sure that is required for upload...
@dominikh While I appreciate the effort to keep the false positive rate as low as possible, I don't agree that those are false positives. We really want to use staticcheck...
On second thought I tend to agree with you. If the doc comment is only `Foo implements Bar.` when you are forced to write it, then not writing anything is...
This needs to be opt-in and default to false, as the older version of baseplate.py/go library will reject hex ids. We already implemented the opt-in in .go, see the comment...
in baseplate.go the behavior is log and move on, which I think makes sense as the connection is udp anyways.
So in JavaScript spec, there's only one type of number defined, which is 64-bit floats: https://www.w3schools.com/js/js_numbers.asp. JSON inherits that from JavaScript. In reality, decoder/unmarshaler implementations can (and often choose to)...
@prashantv thanks. we are currently working around it by wrapping the core: https://github.com/reddit/baseplate.go/blob/master/log/core_wrapper.go if there's a new API to only wrap the encoder I think that would be better than...
@prashantv is there an issue/PR I can follow for the progress of the new encoder-decorator api?