Yuxuan 'fishy' Wang
Yuxuan 'fishy' Wang
Another suggestion, which can be done in a follow-up PR instead, but doing it in this PR will help a lot of the test code: Define a `ValidationError` type in...
This is the correct _type_, yes, but it's not the correct string: ``` $ python3 Python 3.10.4 (main, Mar 24 2022, 13:07:27) [GCC 11.2.0] on linux Type "help", "copyright", "credits"...
note: this is ported from PR from the old repo: https://github.com/dgrijalva/jwt-go/pull/372
a side note is that we already forked the original project with this change (because there was no one reviewing the original pr), and have been running this version in...
@oxisto Thanks for the feedback! >Why is there no EdDSA support? So we are getting some inconsistencies here. That's simply because EdDSA support was added after my original PR :)...
btw if I change from parallel benchmark to sequential benchmark, the time saving is slightly more significant: ``` $ go test -bench BenchmarkRS256VerifyRotation 2022/02/25 11:54:08 Listening... 2022/02/25 11:54:08 Authenticate: user[test]...
>Don't worry about adding more commits, we are using the squash and merge strategy, so we will squash them on our end eventually. That doesn't preserve my git commit message,...
>Can we have something like VerifyKeys in addition to Verify that takes a list of keys and then calls Verify internally However strictly speaking if we extend the interface we...
force pushed with a few minor comment updates, here are the diff from the previous state: ```diff $ git diff --cached diff --git a/ed25519.go b/ed25519.go index d62de12..5f0f565 100644 --- a/ed25519.go...
how long do we have to wait? :)