Yuxuan 'fishy' Wang

Here is an example of how it's used: https://github.com/reddit/baseplate.go/commit/0bd3365a79b6de9865e559a3323fe7e98268b5fc

I would say the map background could also be very useful in certain cases, but yes any map gauge would be useful.

@cptaffe can you please provide a minimal example of thrift file that causes this? In most cases we don't add underscore after `ReadField` so blindly adding an underscore would most...

I think you still need to sort out some CI issues, but please ping me when you are ready and I'll be happy to review it. thank you for doing...

> vt.in: must be in specified values > vt.not_in: must not be in specified values it's not clear to me whether that is an enumeration (e.g. `vt.in = "[1, 2,...

please also resolve the merge conflicts. it would also be helpful (since the review on the spec/proposal part is mostly done) to paste the compiler generated go code into the...

@GuangmingLuo none of the travis test passed, it doesn't look the compiler code compiles, so maybe fix that first? also in my previous comment I said that: >it would also...

https://app.travis-ci.com/github/apache/thrift/jobs/578599367 is a new failure introduced by this PR

Feedback on the compiler generated go code: 1. I thought we agreed on https://github.com/apache/thrift/pull/2469#discussion_r858950006 to use `TApplicationException` for validation errors, but the example is still using `errors.New` 2. In error...

>it could cause serialization /deserialization to fail. I thought that's the point :) But I think it's fine to make it manual checks only first then iterate on top of...