Oliver Stöneberg

Results 1147 comments of Oliver Stöneberg

Still no reply after more than six months - closing.

@orbitcowboy Maybe you could also look at the warnings reported for our own code? Thanks. Also mind the linked tickets which might require some updating after all your additions.

Some `std::string` comparison related benchmarks: https://github.com/llvm/llvm-project/issues/58002#issuecomment-1396950031 I will also do some tests with the stuff we discussed in this PR.

short string: Clang 15 - https://quick-bench.com/q/uMa0PbTdG7CZhp94pk2-aZ9VySE GCC 12.2 - https://quick-bench.com/q/HehK-2CaXR4-g3znvZlh21tzdH4 GCC seems to yield more consistent code compared to Clang. longer string: Clang 15 - https://quick-bench.com/q/2jfuoRSk5wq5bQrvRaqC-gRZxKE GCC 12.2 - https://quick-bench.com/q/_3hA3P1HGN_7juNpdznXvn3iTps...

Turns out all of this is not necessary - see https://github.com/llvm/llvm-project/issues/58002#issuecomment-1396950031. Simply moving the string to compare with into a global `static const std::string` object is enough to produce even...

I updated your changes to apply my findings and added some additional improvements. With those we no longer have need for `matchcompiler.h` which would be great. See https://github.com/firewave/cppcheck/tree/mc-opt with the...

Still no reply after more than six months - closing.

I removed the deprecation stuff as it is part of a separate PR.

The tests are affected by no platform data being set on Windows. The platform file loading is part of the command-line parsing and is not executed before the tests. When...

For some reason the validation is not able to read `�` because it says that `0` is an invalid xmlChar. The application code handles it fine. But I think we...