Oliver Stöneberg
Oliver Stöneberg
I will separate the changes into separate commits for the various warnings (the initial commit mixed together at least three different warnings) so it is better to follow. I would...
`AX_APPEND_COMPILE_FLAGS` already checks if the flag is supported: https://www.gnu.org/software/autoconf-archive/ax_append_compile_flags.html.
> The [-Werror] is needed as otherwise some compilers (particularly clang) may emit a warning rather than an error. I was wondering about that but I omitted it anyways. Will...
I am not 100% sure if the removal of the function is safe as those might be used when the code is in a shared object. But as `PIXMAN_EXPORT` is...
> BTW the pixman files are an oddity. My understanding is they're copied from an old version of the pixman library and used if for some reason the user chooses...
> Yes you're right - disable is the default. Most if not all distros use `--enable-pixman` as they ship the pixman library anyway. Maybe the next release could switch that...
See https://github.com/neutrinolabs/libpainter/pull/21 and https://github.com/neutrinolabs/librfxcodec/pull/59 for upstream fixes.
I finally figured out how to update the submodules so finally here is a rebase.
I think I have addressed everything noted except for the following. > Build also fails with `--enable-neutrinordp` option. To get this option to work you'll need to build NeutrinoRDP:-
`libpainter` submodule still hasn't been updated yet although it was suggested otherwise.