Oliver Stöneberg
Oliver Stöneberg
Still need to integrate/test it with #261 to make sure it does not introduce any issues. It is already actively used by `Macro` though and no tests are failing, so...
Some tests are still failing - will investigate.
The tests failing are the ones with binary characters in the string. We need to add an additional `const char*, int` input for those.
I changed it from a `std::string` input to a `const unsigned char*, std::size_t` and `const char*, std::size_t` (for convienience). The tests pass but it produces valgrind failures in #261.
> The tests pass but it produces valgrind failures in #261. The issue has been fixed - see https://github.com/danmar/simplecpp/actions/runs/8484373804/job/23247192053?pr=261.
I will provide a downstream PR which shows this is working within Cppcheck. We should also do the (planned) release before merging this.
> @firewave would you like that I release simplecpp now or do you have some more fixes..? Do the release so we are in proper sync again. Afterwards this PR,...
Here is the downstream PR using char buffers instead of streams: https://github.com/danmar/cppcheck/pull/6379.
This is basically ready to review but I want feedback from @chrfranke first as he inspired these changes.
No problem. Thanks a lot for the great and thorough feedback! Much appreciated. I tested this with MinGW (native Windows) Cygwin GCC (MSYS2) CMD Powershell Cygwin Shell MSYS2 And it...