image icon indicating copy to clipboard operation
image copied to clipboard
verified publisher icon image-rs

Calculate GCD in Ratio::new

Open krakow10 opened this issue 10 months ago • 2 comments

Hi, I saw this comment and wrote this code on a whim. If it's completely unnecessary that's fine.

krakow10 avatar Feb 01 '25 21:02 krakow10

The code itself looks good to me, but TBH I'm not really sure what the implications of this change are

fintelia avatar Feb 03 '25 00:02 fintelia

I think you can derive (Partial)Eq now, since equivalent ratios are mapped to the same representation.

RunDevelopment avatar Apr 07 '25 14:04 RunDevelopment