findleyr

Results 28 issues of findleyr

While working on gopls, we have a few places where (for example) `*ast.Object` or `*ast.Scope` are handled in a type switch or type assertion, and the `deprecated` analyzer produces informational...

gopls
Tools

Right now, to enable semantic tokens with gopls, it is required to set `"gopls": { "semanticTokens": true }`. Without this setting, gopls will return empty responses to semanticTokens requests (previously...

As we saw in #51219, the fact that SetConstraint eagerly computes the constraint type set makes the API awkward to use for importers. We should investigate if this API restriction...

NeedsInvestigation
early-in-cycle

Telemetry data at https://storage.googleapis.com/prod-telemetry-merged/2023-10-28.json clearly demonstrates a package that cannot be imported: there are in fact two bug reports, one each in type checking (#64235) and analysis (#64236). Clearly some...

gopls
Tools
gopls/telemetry-wins

This issue tracks progress toward releasing [email protected] - [x] create or update gopls-release-branch.0.16 - [ ] update go.mod/go.sum (remove x/tools replace, update x/tools version) - [ ] tag gopls/v0.16.1-pre.1 -...

gopls
Tools

The countertest package exists to test telemetry instrumentation, with a `countertest.Open(dir)` API to initialize the counter file in a temp directory. But on Windows, we can't clean up that directory...

telemetry

The telemetry documentation at https://go.dev/doc/telemetry#basic-counters describes how, _by convention_, telemetry counters can represent a histogram. For example, we currently record latency in gopls using predefined bucket names like "

NeedsFix
telemetry

Add described in golang/go#65917, once Go 1.23 is out we plan to update the gopls go.mod file to say `go 1.23.0`, meaning that building gopls will require a 1.23 toolchain....

gopls