go icon indicating copy to clipboard operation
go copied to clipboard

Published 20 hours ago • verified publisher icon golang

go/types, types2: improve API for setting type parameter constraints in importers

Open findleyr opened this issue 3 years ago • 5 comments

As we saw in #51219, the fact that SetConstraint eagerly computes the constraint type set makes the API awkward to use for importers.

We should investigate if this API restriction can be removed or improved.

CC @griesemer

findleyr avatar Apr 01 '22 14:04 findleyr

@findleyr What is the current status here? This issue is currently in the 1.19 milestone. Should it move to 1.20? To Backlog? Thanks.

ianlancetaylor avatar Jun 24 '22 21:06 ianlancetaylor

Let's bump to 1.20.

findleyr avatar Jun 24 '22 21:06 findleyr

This issue is currently labeled as early-in-cycle for Go 1.23. That time is now, so a friendly reminder to look at it again.

gopherbot avatar Jan 22 '24 16:01 gopherbot

@findleyr Anything to be done here at this point? Let's decide and then do or close.

griesemer avatar Feb 02 '24 17:02 griesemer

Bumping to 1.24 unless you want to close this, @findleyr .

griesemer avatar May 16 '24 20:05 griesemer

This issue is currently labeled as early-in-cycle for Go 1.24. That time is now, so a friendly reminder to look at it again.

gopherbot avatar Jul 23 '24 19:07 gopherbot

This is unlikely to get prioritized, since there are a finite number of importers and they are all working as intended. Therefore, this is an unfortunate API, but we probably won't improve it in the near future.

Keeping this open, but moving to the backlog.

findleyr avatar Oct 24 '24 18:10 findleyr