Piotr Findeisen

Results 644 comments of Piotr Findeisen

> Additionally, it brings the current MV implementation closer to resolving [#23387 (reply in thread)](https://github.com/trinodb/trino/discussions/23387#discussioncomment-10640385) and #23747. is this PR "fixes #23747"?

> Shouldn't there be a change visible in `TestIcebergMetastoreAccessOperations`? from offline feedback -- no, this cuts of AC checks. metastore calls are still there because getting freshness needs it

> The issue states: `The only time we should be checking if the definer has permissions to run the view attached to the query is during refresh.` However, if an...

> This is a proposal to add support for chained function calls, similar to [BigQuery](https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-reference#chained-function-calls), [DuckDB](https://duckdb.org/docs/stable/sql/functions/overview.html#function-chaining-via-the-dot-operator). Are these the only ones which support this syntax sugar? > It improves the...

Yes, AFAICT same test passed against AWS S3, Minio, LocalStack and Moto

`TestNodeStateManager.testDrainToActiveToDrain` and other test methods too eg https://github.com/trinodb/trino/actions/runs/18715979103/job/53375502646

https://github.com/trinodb/trino/actions/runs/19857481712/job/56898975081 ``` [INFO] Error: Errors: Error: TestNodeStateManager.testDrainToActiveToDrain » RejectedExecution Task io.trino.operator.join.JoinTestUtils$$Lambda/0x00000000783f2288@183bd2ae rejected from java.util.concurrent.ThreadPoolExecutor@32f5fa82[Shutting down, pool size = 40, active threads = 13, queued tasks = 0, completed tasks =...

This comes from https://github.com/airlift/airlift/pull/1618. See https://github.com/airlift/airlift/pull/1618#issuecomment-3461957004 for rationale. I think we could revisit the change. It talks about dynamic catalogs, which may make sense. Why isn't the change scoped down...

> * To error when the source of a property is unclear ([this currently just overwrites key values on conflict](https://github.com/airlift/airlift/blob/7c9316c45b2c834b2dc570347412c7110082034e/bootstrap/src/main/java/io/airlift/bootstrap/Bootstrap.java#L276)). i am sure overriding was intentional > Or to change...

> Supports specifying the `identifier_fields` attribute when creating an iceberg table, and can also modify or remove the `identifier_fields` attribute in the Alter table statement. from the iceberg spec >...