Bill Fenner

I apologize for the delay. In order to double-check that the new checksum algorithm gets the right value, I have processed all of the pcap files that @fxlb provided using...

> What are OS/compiler/configure options for this one? It's likely that some of these are specific to 32-bit builds (e.g., i386_el7).

> Was the error on line 549 obtained with the same pcap? I'm sorry, I did this work over a year ago and did not expect to have to provide...

> I understand. Can you run the program again with the lwres pcap to check if it displays one or two error messages? I tried again (with a tcpdump-4.99.2 base)...

During a live capture, the Linux kernel stores the VLAN tag information somewhere else, not in the packet data. libpcap does know about this quirk and builds the filter appropriately...

> I even looked for a way to make tcpdump not load this filter, without success so far. It turns out to be more complex than I remembered: you need...

RFC2045 uses `:=` to introduce rules, which is not ABNF. This could be an RFE for `aex` to handle `:=`.

> To make review easier, please put the first commit ("Move multipart extension object printing to its own function") in its own pull request. This step should be straightforward. Ok,...

Fuzzing found an unchecked call to `in_cksum()`, so I've made this into a draft so that it's not merge eligible until we decide what to do. Should `in_cksum()` itself check...

As discussed, I've added a length check around the call to `in_cksum()`, and added a pcap that contains a sample truncated packet.