tcpdump
tcpdump copied to clipboard
the-tcpdump-group
Parse ICMP Extended Echo (PROBE) (RFC8335)
This adds parsing of ICMP extended echo request/reply, printing ID and seq without -v, and additional information with -v.
I've made two changes here; the first one is just moving the existing parsing of extended icmp objects to a separate function, and the second one adds the extended echo functionality, to make reviewing easier. I can squash them before merge if that's preferable.
To make review easier, please put the first commit ("Move multipart extension object printing to its own function") in its own pull request. This step should be straightforward.
To make review easier, please put the first commit ("Move multipart extension object printing to its own function") in its own pull request. This step should be straightforward.
Ok, I've opened #1119 and will rebase this after that's merged.
Fuzzing found an unchecked call to in_cksum(), so I've made this into a draft so that it's not merge eligible until we decide what to do.
Should in_cksum() itself check for enough bytes, or, should all of its callers check before calling it?
As discussed, I've added a length check around the call to in_cksum(), and added a pcap that contains a sample truncated packet.
[Rebased. The build errors don't seem to be related to this PR. More tests needed].