Bill Fenner

> Do you think a separate thread around `print_packets_captured()` would be easier to implement? Would it still be portable enough? I've always tried to avoid threads in portable code, but...

> So does that test program catch SIGINT? Not explicitly, but strace shows that someone is (maybe python's KeyboardInterrupt handler). I'm ok with punting on that for now and focusing...

> > The next thing it does is register fd in our event manager, and it's plausible that this (perhaps incorrectly) causes a call to pcap_next() - but given that...

> > > > The next thing it does is register fd in our event manager, and it's plausible that this (perhaps incorrectly) causes a call to pcap_next() - but...

I have no further followup.

This looks correct to me: multiple child processes exiting can result in only a single SIGCHLD, so looping with waitpid() to reap them all is correct.

> > Thank you for preparing these changes. Do you still have the UBSan messages? Does `make check` pass in your working copy? I will recreate the UBSan messages, by...

P.S. I will also squash the "Address integer overflows" commit into the "ISO:" commit once my discussion with fxlb is complete.

The integer overflow commit is still separate, because I want to validate it against a separate implementation of this checksum implementation that I have access to. I updated the .out...

I didn't think it was worth pushing my fix for the illumos build, but I have done so now to avoid getting confused by ``` Your branch and 'origin/fenner-ubsan-fixes' have...