Felix Becker

Results 408 comments of Felix Becker

I think one problem is that aggregate-error puts all the stacks of the errors into `message`, but imo `message` should only contain the aggregated `message`s. The aggregated stacks with messages...

Tested Chrome does not invoke `toString()` for errors, but it uses `stack`, and it's possible to assign `this.stack` to a custom concatenation of everything

One idea would be to turn this module into a factory function `createAggregateError()` for the standard global `AggregateError` that does the smarter error messages. It could also make sure error...

I'd love to query failed jobs from a pipeline and restart them with a cmdlet

Is that code that you tried to highlight? Please provide some more details of what you tried to do.

Hmm I don't think so. That would require some kind of plugin into the REPL

The styles for these are currently all set to `plain`. Would you like to contribute styles for them? https://github.com/felixfbecker/cli-highlight/blob/41db84db615000b7db5a365d4c86e419e512a654/src/theme.ts#L457-L480

okay, so that seems to be required, which is not that nice... but still, even if they do get cleaned up on $destroy, if the scope is not destroyed it...

@cvuorinen > Maybe should detect if WeakMap is supported and use it if it is and fall back to current implementation if not? at that point you are essentially using...

@cvuorinen Well, in turn the ones who target newer browsers end up with either memory leaks or dead code. ![image](https://user-images.githubusercontent.com/10532611/26842281-8f1a676a-4aec-11e7-90dc-fa143f74d428.png) Adding polyfill on the other hand is a matter of...