Felipe Cavalcanti

Results 135 comments of Felipe Cavalcanti

do you mind sending a PR? at wildlife we don't use the Websocket acceptor, only raw TCP, this is why this is not a priority for us to fix

Right now you would need to call `func GroupMembers(ctx context.Context, groupName string) ([]string, error)` for each group you have and see if the player is there. an alternative would be...

I didn't get what you're saying. Pitaya-cli should test WS first, with and without tls and then raw TCP with and without TLS https://github.com/topfreegames/pitaya-cli/blob/29b01080228daa063a5fab10bcad83f2f2fb74b9/helpers.go#L52-L67

true, it's useful sometimes when doing integration/manual testing

what do you mean? inside the same session, it's expected that the messages will be processed in order because we're using either TCP or WS as acceptor. unless you're trying...

EDIT: Ok now I see what you say, we have a single coroutine for receiving the messages from each client, but indeed we have multiple threads for processing them, so...

You're right! We should test it. We can't make the interface private because this would eliminate the possibility for people to implement their own ServiceDiscovery, and extensibility is one of...

Also, in my [sidecar branch](https://github.com/topfreegames/pitaya/tree/sidecar), I did some project structure refactoring to better fit into go's best practices and upgraded dependencies, I wouldn't like to bump the major again to...