Matthias Fasching

Results 151 comments of Matthias Fasching

Same test in hare3 package: https://github.com/spacemeshos/go-spacemesh/actions/runs/10401170661/job/28803157041

Different sub-test but looks like same issue: https://github.com/spacemeshos/go-spacemesh/actions/runs/10581561061

Another subtest (`TestHare/with_inactive`), looks to be the same issue: https://github.com/spacemeshos/go-spacemesh/actions/runs/10849922157/job/30110182018

The contents of this PR have been integrated into https://github.com/spacemeshos/go-spacemesh/pull/6307

Since the fix only works after we update our CI runners, I'll set this to draft for now.

Abandoning for now. The warning are annoying but getting rid of them seems not to be worth the effort.

As stated in the discussion on the #6003, maybe we can tie transaction release / rollback to the context cancellation with `context.AfterFunc`: https://github.com/spacemeshos/go-spacemesh/pull/6003#discussion_r1723206141

This is the code that deletes the namespace after a test: https://github.com/spacemeshos/go-spacemesh/blob/787351f6a789c0446b37acf27aecc2a7afd1343d/systest/testcontext/context.go#L369-L377 So if you want that test to stick around you can either ensure that `cctx.Keep` is true by...

Superseded by https://github.com/spacemeshos/go-spacemesh/pull/6353

I don't think this makes sense to implement independelty of the actual logic behind malfeasance handler and publisher and should be integrated into the bigger story here: https://github.com/spacemeshos/pm/issues/331