Matthias Fasching
Matthias Fasching
I did some additional improvements. Now Sign2 and Verify2 are basically the same as the standard library versions (also almost exactly the same code) and `ExtractPublicKey` is now 2.5x faster...
@Waterman1997 thanks for your contribution! 🙂
To avoid having to specify the same version multiple times a `Makefile` could be used that installs the tools once in the required version. With `tools.go` the issue remains that...
Theoretically you could have a `tools` module, `cd` into that directory and install the tools from there. This would prevent polluting dependencies in the `libp2p` module. However this still causes...
It doesn't need to be global: ```Makefile export GOBIN := $(abspath .)/bin export PATH := $(GOBIN):$(PATH) .PHONY: install install: go install google.golang.org/protobuf/cmd/[email protected] go install go.uber.org/mock/[email protected] .PHONY: generate generate: install go...
`go install` overwrites existing binaries with the same name. Just like it does if used to install a tool globally: ```bash ~/workspace$ GOBIN=$(pwd)/bin go install go.uber.org/mock/[email protected] go: downloading go.uber.org/mock v0.4.0...
Interoperability testing fails for head, not because of this change but probably because of this PR: https://github.com/libp2p/go-libp2p/pull/2780 It seems like updated `webtransport` isn't backwards compatible.
> > With tools.go the issue remains that go.mod is polluted with dependencies that are only needed for its tools rather than the library itself and that the tools installed...
bors merge
bors merge