Matthias Fasching
Matthias Fasching
changes look OK for me - for the linter issues: a multi-line function definition needs to look like this for `gofumpt` to not complain: ```go func (b *Builder) getExistingChallenge( logger...
bors merge
bors merge
superseded by https://github.com/spacemeshos/go-spacemesh/pull/6043
I assume the new schema should look like this? ```sql CREATE TABLE atxs ( nid INT NOT NULL AUTO_INCREMENT, id CHAR(32) UNIQUE, prev_nid INT, epoch INT NOT NULL, effective_num_units INT...
> Re PoET proof storage optimization: it looks like that deserves a separate issue indeed, and should probably be implemented separately from the rest of this optimization. sure 🙂
Regarding Avoiding code duplication in the tests: I don't see any reason to have a generic test for two different packages/implementations. Either we should make the package itself generic and...
I would also say return an error when opening a DB and the schema doesn't match (that error should gracefully shut down the node before it even fully started) and...
> One thing that was not fully decided above is where to put the developer docs for schema handling, which I'd prefer to have somewhere (`README.md` seems not to be...
Abandoning for now. The warning are annoying but getting rid of them seems not to be worth the effort.