go-spacemesh icon indicating copy to clipboard operation
go-spacemesh copied to clipboard

Fix macOS linker warnings

Open fasmat opened this issue 1 year ago • 2 comments

Motivation

This should fix linker warnings we keep seeing on macOS.

Merge after https://github.com/spacemeshos/post/pull/297

Description

Update post library and remove duplicate LDFLAGS definition in Makefile.

Test Plan

  • existing tests pass.

TODO

  • [x] Explain motivation or link existing issue(s)
  • [x] Test changes and document test plan
  • [x] Update documentation as needed
  • [x] Update changelog as needed

fasmat avatar Jul 03 '24 10:07 fasmat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.7%. Comparing base (517c305) to head (dc10746). Report is 11 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6095     +/-   ##
=========================================
- Coverage     79.7%   79.7%   -0.1%     
=========================================
  Files          328     328             
  Lines        42904   42904             
=========================================
- Hits         34224   34208     -16     
- Misses        6752    6764     +12     
- Partials      1928    1932      +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 03 '24 11:07 codecov[bot]

Since the fix only works after we update our CI runners, I'll set this to draft for now.

fasmat avatar Jul 13 '24 23:07 fasmat

Abandoning for now. The warning are annoying but getting rid of them seems not to be worth the effort.

fasmat avatar Nov 05 '24 15:11 fasmat