Anton Fedorov
Anton Fedorov
This bug is only one thing that stops me from upgrading to 7.x from 6.x (we using this feature for selectivity checks in CI for our monorepo setup). @zkochan I...
Looks like I figured out what causes the problem. I added some logs [here](https://github.com/pnpm/pnpm/blob/f9c275ab461fd1356427aac2de6af804f3c9e9fb/packages/filter-workspace-packages/src/getChangedPackages.ts#L58) to see the original error: ``` spawn git ENOENT at Process.ChildProcess._handle.onexit (node:internal/child_process:283:19) at onErrorNT (node:internal/child_process:478:16) at...
Deep dived into internals and it seems like the problem is located here: https://github.com/pnpm/pnpm/blob/47140dcf995403ebce269b03c8a2db8a646fa421/packages/filter-workspace-packages/src/index.ts#L190 The `selector.parentDir` sets here: https://github.com/pnpm/pnpm/blob/47140dcf995403ebce269b03c8a2db8a646fa421/packages/filter-workspace-packages/src/parsePackageSelector.ts#L59 There is regexp for `matches`: https://github.com/pnpm/pnpm/blob/47140dcf995403ebce269b03c8a2db8a646fa421/packages/filter-workspace-packages/src/parsePackageSelector.ts#L37 For the input string `{packages/*}[origin/main]`...
It turns out that in my case there is no need in globs when filtering by subfolder with `[since]`. Excluding filters with globs works just fine: ``` pnpm list --filter="...{packages}[origin/main]"...
Looks like metadata of packages are not downloaded via `pnpm install` because cache dir is empty. But after first run of `pnpm deploy` the metadata will be downloaded and second...
@benjitrosch hi there! By any chance you could provide a link to an example of failed GH Actions run, just to better understand the context of what exactly is wrong...
Hey @jan-molak, thank you for a detailed answer! Here are my thoughts regarding it: > Network-restricted environments typically have access to a local artifact registry like Artifactory, Nexus, or similar....
> > This is probably not a blocker though as for the weirdest setup this can be eliminated by pushing a Serenity BDD jar file straight to the git repo...
Your plan makes sense to me, let's give it a try. Since it's not a breaking change, if installing via `postinstall` script won't be ideal, it's still possible to change...
Any updates on the future of this lib? I see it was moved to a new org recently, does that mean we should expect any updates soon?