react-daisyui icon indicating copy to clipboard operation
react-daisyui copied to clipboard

Not Installing with daisyui 5.0?

Open eltonSalanic opened this issue 9 months ago • 19 comments

Whenever installing react-daisyui, i get

Could not resolve dependency: npm ERR! peer daisyui@"^4.12.10" from [email protected] npm ERR! node_modules/react-daisyui npm ERR! react-daisyui@"^5.0.5" from the root project

Downgrading DaisyUI to 4.12.10 causes this error to show up when running react app: (client) Pre-transform error: addUtilities({ '@media (min-width: 640px)' : … }) defines an invalid utility selector. Utilities must be a single class name and start with a lowercase letter, eg. .scrollbar-none. Plugin: @tailwindcss/vite:generate:serve

If anyone has any fixes, let me know thank you :)

eltonSalanic avatar Mar 08 '25 06:03 eltonSalanic

Hi @eltonSalanic,

I'll get to work on a 5.0 migration soon. Unfortunately, I haven't been on a team that uses daisyui—let alone Tailwind—for a few years now, so keeping up with it is much harder for me than before.

Look out for a new version this weekend.

benjitrosch avatar Mar 11 '25 06:03 benjitrosch

Should have added a "maybe this weekend," sorry folks, ended up getting sick!

benjitrosch avatar Mar 17 '25 13:03 benjitrosch

Looking forward to it

Joeao avatar Mar 22 '25 17:03 Joeao

@benjitrosch Any news on this?

dugajean avatar Apr 04 '25 00:04 dugajean

If you like, you can try this one.

https://github.com/yoshi6jp/rsc-daisyui

npm storybook

yoshi6jp avatar Apr 16 '25 12:04 yoshi6jp

Working on it today, in fact. I'll be skipping tests for now to get v5 out faster. That said, PR's from others are always welcome!

benjitrosch avatar Apr 16 '25 17:04 benjitrosch

Here's the PR: #472

Not all stories or tests have been updated, that will have to happen after the first release. I'll be making some fixes to the Storybook deployment and then merging this ASAP.

benjitrosch avatar Apr 16 '25 20:04 benjitrosch

Excited to start using it! I will start a new project soon so I would love to be able to use the last version

axvemi avatar Apr 30 '25 17:04 axvemi

Is there any update on getting the pr merged and released?

anthonyptetlow avatar May 05 '25 14:05 anthonyptetlow

Or even steps to install the pull request version? I tried to install from github but that doesn't work when it needs to be built into the dist folder first.

anthonyptetlow avatar May 08 '25 19:05 anthonyptetlow

@benjitrosch I am happy to help with anything that needs done to get the version released. Am I able to help or can you put out the release?

anthonyptetlow avatar May 23 '25 09:05 anthonyptetlow

@benjitrosch I am happy to help with anything that needs done to get the version released. Am I able to help or can you put out the release?

Sorry for the delay. Between being busy at work and getting married next week, I haven't had time to dedicate to this library. Apologies to everyone who depends on it.

The one remaining task for a 5.0 release is to update the GitHub actions for NPM release + GH pages Storybook deployment. Unfortunately, the actions we were using before are now outdated. If you could find some time to look into fixing those, that would unblock release. Otherwise, I'll try to find some time within the next month.

benjitrosch avatar May 24 '25 23:05 benjitrosch

Congratulations on getting married! Hopefully, I speak for everyone by saying we can revisit this in a month. You have crafted a very valuable library, but there are some things much more important.

Have a fantastic day 🥳

topgun100 avatar May 26 '25 11:05 topgun100

Congratulation!

namnm avatar May 26 '25 16:05 namnm

Any update here? :)

Szasz1989 avatar Jun 16 '25 09:06 Szasz1989

Congratulation!

kahirokunn avatar Jun 21 '25 14:06 kahirokunn

Hi, when can we expect new release with DaisyUI 5 compatibility? We are blocked by this :/

robert-zaremba avatar Sep 15 '25 07:09 robert-zaremba

Hi, when can we expect new release with DaisyUI 5 compatibility? We are blocked by this :/

@robert-zaremba the component upgrade work is done, all that remains is refactoring our release Github Actions (the packages used are outdated and will no longer run, and there have been many breaking changes since then).

The V5 release will happen when either I can find the time to research new packages and rebuild the release flow, or when someone else makes a PR to fix releases.

benjitrosch avatar Sep 23 '25 16:09 benjitrosch

@benjitrosch hi there! By any chance you could provide a link to an example of failed GH Actions run, just to better understand the context of what exactly is wrong with current setup? So far I was able to see that release-pr job of release-please-pr workflow is failing on recent commit because branch release-please--branches--main--components--react-daisyui already exists with a commit that is not presented in the main branch since PR with the last release (#465) was closed, but the release branch was not deleted. It looks like deleting this branch might help as it'll be re-created again by the release-pr job, at least we'll might be able to see new errors to understand further steps. Would you mind to try it?

upd: found some warnings in release job, prepared PR to address them: #483.

fapspirit avatar Oct 13 '25 06:10 fapspirit