fanquake
fanquake
Concept nack. This is something a user can do on their own system if they want to use nproc generally. However it's not a requirement for building bitcoind.
I think the only place this might make sense would be in the developer documentation. I don't think we should be adding additional things as base dependencies for os specific...
> as CI integration still needs to be added. Not sure. As long as we aren't shipping this in releases, I don't think it needs to be added to the...
> It is documented, and it is pre-defined by CI itself: It's not in our docs, or in our CI code, which means our CI would "work", because a third...
> This does not apply to the "raw" GitHub Actions workflows, where this code takes effect. Can't someone just compile and run the same binaries locally?
> This PR adds a way to suppress the abort message box when running test_bitcoin.exe and fuzz.exe built with the debug runtime library on Windows. Given this isn't being used...
What is the status of this?
> During my quick (and possibly not thorough) tests, I was unable to reproduce the issues mentioned in those PRs on our codebase. Seems odd to not pull in all...
Is this currently an issue for anything? If the check is broken, then it should be fixed before we start using it.
Guix Build: ```bash bcf993e048118c80beae601700c50f8d707474b0e5f89359dfc8781a12efee81 guix-build-c0f41523973e/output/aarch64-linux-gnu/SHA256SUMS.part a6cf6122393f86b8a34e036b8a237daa3153613d154eae2f8c66720c8bad0b52 guix-build-c0f41523973e/output/aarch64-linux-gnu/bitcoin-c0f41523973e-aarch64-linux-gnu-debug.tar.gz 3330a1a5848fa80f24b181f8fe22341dca8abe9a1934a8c75834f51b311ad780 guix-build-c0f41523973e/output/aarch64-linux-gnu/bitcoin-c0f41523973e-aarch64-linux-gnu.tar.gz eb8ba4643c8b2774e924c45f691417f3aa37bf71c9528f21763bdb47bbb33fe6 guix-build-c0f41523973e/output/arm-linux-gnueabihf/SHA256SUMS.part 47cc0bdec05bc41bb937e5c0f77c1e5a4c3fd98c61675786e0a728542ffb15ee guix-build-c0f41523973e/output/arm-linux-gnueabihf/bitcoin-c0f41523973e-arm-linux-gnueabihf-debug.tar.gz 7fe7b9f9085a8cb80afcf068cff74caf4aa56b06a64ccffd5dd975c2af192447 guix-build-c0f41523973e/output/arm-linux-gnueabihf/bitcoin-c0f41523973e-arm-linux-gnueabihf.tar.gz 0b3398de2a918cef87dc3a8d385ea79c254dd363567d5bd6e87d765a238728b5 guix-build-c0f41523973e/output/arm64-apple-darwin/SHA256SUMS.part 068620b11ad97ef8adcc7ab8f8c6bc94608008e40f491b4fa0e69b19a2e4dd30 guix-build-c0f41523973e/output/arm64-apple-darwin/bitcoin-c0f41523973e-arm64-apple-darwin-codesigning.tar.gz 3a698a972be14c8a886b44e44206a1eacb4482443935a2487951d0cc7190f22a guix-build-c0f41523973e/output/arm64-apple-darwin/bitcoin-c0f41523973e-arm64-apple-darwin-unsigned.tar.gz 536927c6ff930e665bd00175a5cbb6d26af8ffcee3f5d82a0417c900d64b6c39 guix-build-c0f41523973e/output/arm64-apple-darwin/bitcoin-c0f41523973e-arm64-apple-darwin-unsigned.zip cea669c6dc7dcaff3c59bbdb3478519474579f2023b2f7e3524841f8e3c88294 guix-build-c0f41523973e/output/dist-archive/bitcoin-c0f41523973e.tar.gz 8f05da30224c64bc5316bef9b03d8c8a8e9cade4284628cdd6ba2b42d3b19790 guix-build-c0f41523973e/output/powerpc64-linux-gnu/SHA256SUMS.part c964fbef6e9356f8ee271dce1f22a3ff531b3bece20645a6370dccfa0921aa32 guix-build-c0f41523973e/output/powerpc64-linux-gnu/bitcoin-c0f41523973e-powerpc64-linux-gnu-debug.tar.gz 6d7ed07d0291e95e15f7827cee7c4d9c91405369b468ca06560f617ddfd77916...