fanquake

Results 921 comments of fanquake

> Feel free to pick [this](https://github.com/hebasto/bitcoin/commit/be6354db410d162f82b5e3c76d964c0365e51d96) translation update There's not so much of a rush here that this should bypass the normal PR & review process. This should first be...

Closing, given v28.0 is tagged.

What change in behaviour should be expected here?

> you can see this variable only has meaning when cross compiling for windows and android Given, for example, that if you cross-compile for macOS, with this PR, you end...

> Concept ACK, but we need more docs here. > I can't tell (even from looking at the CMake docs) what macOS should be set to and why you've chosen...

https://github.com/bitcoin/bitcoin/pull/29847/checks?check_run_id=23664375509 ```bash Run base_encode_decode with args ['/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz', '-runs=1', PosixPath('/ci_container_base/ci/scratch/qa-assets/fuzz_seed_corpus/base_encode_decode')]INFO: Running with entropic power schedule (0xFF, 100). INFO: Seed: 1375269970 INFO: Loaded 1 modules (578208 inline 8-bit counters): 578208 [0x55e843d75228, 0x55e843e024c8),...

> I don't yet understand how we expect this code to become more and more maintainable, if we don't regularly leave the campground cleaner than we've found it. The issue...

Concept NACK on the approach here (CI is showing why it wont work with depends, I assume it will also break other builds (where we haven't built the libs)). I'd...

Guix building 89f8e8e7f5828b1d06925e036c16eda050b05c81 on `aarch64` doesn't work: ```bash time HOSTS="x86_64-linux-gnu" ./contrib/guix/guix-build CXXLD test/test_bitcoin x86_64-linux-gnu-ld: /bitcoin/depends/x86_64-linux-gnu/lib/libevent.a(buffer.c.o): error: missing IBT and SHSTK properties x86_64-linux-gnu-ld: /bitcoin/depends/x86_64-linux-gnu/lib/libevent.a(bufferevent.c.o): error: missing IBT and SHSTK properties x86_64-linux-gnu-ld:...