fanquake

Results 1003 comments of fanquake

> Moreover, the new non-released code breaks our fuzzing tests. See: https://github.com/bitcoin/bitcoin/issues/30096. I'm not so sure that's relevant. I think the conclusion in that issue was that vcpkg should probably...

Killed and re-ran the never ending CIs: https://cirrus-ci.com/build/4760419941744640.

Is this still meant to be a draft?

As mentioned, what you're adding is already present in this file, so if you're re-ordering things, you'll need to remove the second occurence.

Thanks. You'll need to squash your commits.

> Makes bitcoind spin during startup, waiting for a debugger to be attached. Can you explain more? If you want to run under a debugger, then why not just start...

Ideally we wouldn't be adding debug code, to production binaries, to facilitate using an IDE. Can you configure your IDE to do something like the equivalent of using `gdb`/`lldb`, and...

> The windows cross-built job is failing on the rate_limiting test at every file-size comparison. I don't have a windows machine to debug this, but I think maybe fs::file_size is...