fanquake

Results 873 comments of fanquake

According to https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fopen-wfopen?view=msvc-170 `x` should be supported, but maybe it is broken.

Note there are at least two defines missing from the scriptied diff (`_TIME_BITS` & `__MINGW_USE_VC2005_COMPAT`), if using Autoconf 2.72 , however that should not make a difference here. Looks like...

```bash CXX qt/libbitcoinqt_a-moc_bitcoin.o qt/macnotificationhandler.mm:27:9: error: 'NSUserNotification' is deprecated: first deprecated in macOS 11.0 - All NSUserNotifications API should be replaced with UserNotifications.frameworks API [-Werror,-Wdeprecated-declarations] NSUserNotification* userNotification = [[NSUserNotification alloc] init];...

> I don't understand what you mean. Me either. The code that is producing warnings is definitely in our source tree. I don't see how this is related to the...

I just had a look, and anyone compiling on macOS, with Qt 6.6.1, will still see these exact same deprecation warnings. So this isn't solved by Qt 6.

I guess mark as draft or something else for now then? This can't be merged as-is, because the comments in the config of files are not correct.

NACK - this currently disables all compiler warning output in the CI for an entire release platform, rather than fixing GUI code? Not sure that is the right tradeoff.

> @fanquake Do you think it's too late for this for v27? I think it's still possible to do this for v27. It's not clear to me that the other...