Kirill Fomichev
Kirill Fomichev
https://github.com/indutny/elliptic/issues/191 (`asn1.js` need bump to 5.3.0)
Instead `.toString` lookup table can be used, need check how this can be applied in bn.js context. See https://github.com/feross/buffer/pull/245
English isn't my native language, but wouldn't `Compliant modules` is better than `Modules that use this interface`?
I like `flat-square` more than just `flat`. I'd like to see it here :)
API docs says nothing about what encode/decode should to do when buffer is too small. Most of modules that uses this interface throwing errors (for example: `buffer.readUInt32BE` could throw `RangeError`),...
Thank you for package ~, as I understand this work was inspired by by [Go context](https://golang.org/pkg/context/)?~ Any reason why you export instance of `Context` instead `Context` itself?
Macros like `counter!` / `gauge!` and other possible things https://github.com/timberio/vector/pull/5209#discussion_r529899623
In https://github.com/timberio/vector/pull/4500 I add `tags!` macro, as @jszwedko [noted](https://github.com/timberio/vector/pull/4500#discussion_r507790177) there few other places where similar pattern is used. Maybe we should define tags related macro/macros in some place for usage.
For async build method in our components, we use [async-trait](https://crates.io/crates/async_trait) crate because currently async Traits are not supported. Unfortunately as a result of `async_trait` usage sometimes the compiler does not...
Issue #35 Decide just drop code, interesting thing. Fields in struct same, but by some cases errors on tests. Currently do not know llparse too good for say why :thinking:...