llparse icon indicating copy to clipboard operation
llparse copied to clipboard
verified publisher icon nodejs

src: pack struct by sorting fields

Open fanatid opened this issue 6 years ago • 5 comments

Issue #35 Decide just drop code, interesting thing.

Fields in struct same, but by some cases errors on tests. Currently do not know llparse too good for say why :thinking:

btw, should not i8/i16/i32/i64 be u8/u16/u32/u64?

fanatid avatar Jan 11 '20 08:01 fanatid

Sorry, I do not think that I understand. I should change something in bitcode for fixing tests?

fanatid avatar Jan 14 '20 15:01 fanatid

Not in the tests. The order of fields has to be changed in the bitcode generator.

indutny avatar Jan 14 '20 15:01 indutny

Thank you. I see that I also need change fields in bitcode / js: https://github.com/nodejs/llparse/blob/564e5c4363d95cc14bdadb27d165082f0f3e09f0/src/implementation/bitcode/compilation.ts#L124 https://github.com/nodejs/llparse/blob/564e5c4363d95cc14bdadb27d165082f0f3e09f0/src/implementation/js/index.ts#L47

fanatid avatar Jan 14 '20 16:01 fanatid

Well, maybe not in JS, but you got it right!

indutny avatar Jan 15 '20 21:01 indutny

I fixed code for bitcode.

fanatid avatar Jan 20 '20 19:01 fanatid