Kirill Fomichev
Kirill Fomichev
For reference, PR in node: https://github.com/nodejs/node/pull/18395
Thanks. Probably we need to move this assertion before `if`. https://github.com/indutny/bn.js/blob/db57519421f0c47c9f68c05fa6fc12273dcca2c2/lib/bn.js#L2854 Currently, I'd recommend using `BigInt` instead of `bn.js`.
v5.0.0 introduced some renames, you can find full lines of changes in this PR: https://github.com/indutny/bn.js/pull/219 I think npm shows v4 as `latest` because they define the latest version by date....
I fixed `latest` tag (thanks to npm support for `npm dist-tag add @ latest`), now `latest` point to `5.2.0`.
I think that this will make things more complex - you did not do same for hex base - `out.length % padding !== 0` still here and still not clear...
What you like to see as BigInt support? Accept BigInt in constructor/methods?
Can you paste what number used as input, what result received and what expected? Is there any difference between pass number in base36 or in base10 on creating BN number?...
If you paste JS example with BN and code which do same on python (bignumber native support) which demonstrate that result incorrect -- this will be great.
@astiob my request was related with easiest reproducing problem, it's hard dive into 3rd problem. Can confirm bug in library, ping @indutny I found that problem related with [jumboMulTo](https://github.com/indutny/bn.js/blob/24cc2dd51b58694088a637a314689f61c9ba65a4/lib/bn.js#L1693-L1697) (function...
I think that multiplication with FFT should be disabled while problem is not solved. As @chjj done ^^^