Kirill Fomichev
Kirill Fomichev
Any plans regarding https://github.com/indutny/bn.js/issues/35 as part of next major release ?
@indutny just would like to know your opinion about Buffer ([node](http://nodejs.org/api/buffer.html)/[browser](https://github.com/feross/buffer/)) instead Array here
out of curiosity... as I understand you used Array instead Buffer for zero dependencies, why not Uint8Array for example? if there were no question about dependencies, would you use Buffer...
oh, okay, so the main reason is performance? How long ago are you tested? Array allocation work better? Maybe I'm wrong, but as I remember, Buffer allocate more then requested?...
Thank you for explanation. Can you publish your tests for Array/Buffer/Uint8Array comparison?
I think #90 #91 #141 #151 should be added to list
@axic how you think, what `toJSON` actually should return?
wow, currently this looks like not padding at all? :thinking: https://github.com/indutny/bn.js/blob/e69c617b3297b99aca429f30842e27979ef9beb5/lib/bn.js#L474
I think this is expected result, check constructor function: https://github.com/indutny/bn.js/blob/24cc2dd51b58694088a637a314689f61c9ba65a4/lib/bn.js#L22-L24
What we should do with code and licenses which was moved from crates to vector? Examples: - https://github.com/timberio/vector/blob/947319bb59f0841d245c47683d0279056f19b7e8/src/sinks/util/retries.rs#L182 - https://github.com/timberio/vector/blob/947319bb59f0841d245c47683d0279056f19b7e8/src/sink.rs#L1