Matt Styles

Results 86 comments of Matt Styles

The pointer registration mechanism is copied from `sf::SoundBuffer` - unless I've missed something then it should be at least as reliable as losing a `sf::SoundBuffer` while a `sf::Sound` is still...

I completely agree, it separates concerns much more cleanly, and allows users to inherit `sf::SoundEffect` (assuming they're willing to include the OpenAL headers). I've not tested every single effect listed...

As far as I know OpenAL-soft supports macOS and iOS. If SFML were to use that it would also make the behaviour of the effects consistent across platforms.

I've added an empty implementation for IOS, but the CI doesn't seem to recognise the SFML_SYSTEM_IOS definition from Config.hpp?

> > > `setVolume` currently deals in the range of `0.f` to `1.f`, which is different to the `sf::SoundSource::setVolume` with a range of `0.f` to `100.f`. Both work since it's...

On further examination `setVolume()` actually multiplies the output of the associated `SoundSource`, meaning that 0 - 1 is a more reasonable range than 0 - 100, as well as it...

Hi! To address your questions: - I have no idea 😄 - Of course, it's all under the SFML license - to test it out just clone [my branch](https://github.com/fallahn/SFML/tree/audio_effects) -...

> > It's still not clear to me why effect can't be a const ref here, same as sf::SoundBuffer is passed by const ref to sf::Sound::setBuffer. To remove effect, we...

This is a well documented issue with SFML vertex arrays, rather than the map loader itself. This post has some details why it happens: https://en.sfml-dev.org/forums/index.php?topic=15338.0 (or just search for SFML...

Short answer: not easily, it would pretty much be a re-write. The example is really just that: an example. Have you tried some of the suggested solutions in the forum...