Facu Spagnuolo

Results 12 comments of Facu Spagnuolo

Before tackling this issue please list all the maths we are going to test to make sure we are aware of them all. Apart from testing, we can think if...

> I am still a bit conflicted about how much complexity this emergency address would add and whether we should just trust the root authority for an initial version. I...

> With the current implementation this actually wouldn't be possible (as none of its methods are killSwitchProtected), but I agree we should be set up to handle this case (or...

I see, and I think it's a particular case of what I described initially in the issue's description actually. We will still need to whitelist the Voting app, but also...

@izqui @bingen @sohkai thanks for your reviews, I already addressed all your comments, and I really like how this is looking :) OTOH, I've been exploring many different edge cases...

Thanks for the review @sohkai! I already addressed/answered all your comments. Feel free to take another look if you want.

The coverage task is failing because there are some tests that fail but only when measuring coverage. I've trying to debug it locally but it was completely cumbersome and I...

Thanks for your review @bingen! Although, I think it is more interesting to review directly the last approach we decided to follow :)

@izqui I've decided to drop the idea of calculating the amount of gas to be refunded to the off-chain service since it was actually taking a lot of gas to...