aragonOS icon indicating copy to clipboard operation
aragonOS copied to clipboard

Published 20 hours ago • verified publisher icon aragon

Kill switch: Polish and integrate MVP version

Open facuspagnuolo opened this issue 5 years ago • 3 comments

Follow up on #516

Based on an offline discussion we had about the next-steps regarding the kill-switch topic, we decided to:

  • [x] Drop the kernel level kill-switch idea, at least for the MVP version
  • [x] Simplify the whole architecture to support only application level kill-switch using severities
  • [x] Support having one issue registry per application
  • [x] Integrate with the rest of the aragonOS components
  • [x] Investigate how an organization is able to recover

Summing up, the new contracts model looks like: image

And the contracts interaction is the following: image

facuspagnuolo avatar Apr 30 '19 18:04 facuspagnuolo

@izqui @bingen @sohkai thanks for your reviews, I already addressed all your comments, and I really like how this is looking :)

OTOH, I've been exploring many different edge cases about recoverability, and unfortunately my conclusion is that we will need to keep working on further models to have a robust implementation. I filed an issue sharing my thoughts on the matter, feel free to comment and leave feedback there.

However, based on the last changes, I think we can are pretty to close to have a full MVP version of the kill-switch, we just need to decide the which will be the MVP version of the recoverability process. IMO, I think we can do something with the voting app similar to what I did in https://github.com/aragon/aragonOS/pull/518/commits/7f73ac36677f364bf1c22aab84bfce9f3fb5866e, please follow-up in the issue mentioned above.

facuspagnuolo avatar May 08 '19 05:05 facuspagnuolo

Thanks for the review @sohkai! I already addressed/answered all your comments. Feel free to take another look if you want.

facuspagnuolo avatar May 20 '19 21:05 facuspagnuolo

The coverage task is failing because there are some tests that fail but only when measuring coverage. I've trying to debug it locally but it was completely cumbersome and I couldn't get to know what was going on. After that, I tried running solidity-coverage on using ganache-cli instead of testrpc-sc using frangio's fork and it passed. Definitely solidity-coverage is an outdated tool that has already been giving us several headaches 😕

facuspagnuolo avatar May 23 '19 22:05 facuspagnuolo