Fabian Schneider
Fabian Schneider
Seems like this bug could have a higher extend than expected. All illuminations add 0.5 to their voxel positiions, like this `device_position = list(self.device_position_mm / spacing + 0.5)`. But the...
I have already worked on this, can open a PR soon.
There are still some rot90 left in simpa, mostly in the plotting functions and some tests (also in KWaveAcousticForwardConvenienceFunction, which is one reason why the output looks so strange). We...
Actually removing dx * GEL_LAYER_HEIGHT completely can place the sensors outside of the volume. To avoid this we need to add at least dx. But then we should probably add...
@kdreher I just noticed, that the direction vector here is written in the wrong member variable. Its should be self.normalized_source_direction_vector and not self.direction_vector_norm. So the input direction never had an...
Yes, looks good. Thanks!
Thats because MCX recently made jnii the default file format. Theres already a [pr](https://github.com/IMSY-DKFZ/simpa/pull/246) to fix this, but it's not merged yet.
I just looked into `get_array_binary_mask` and by only refactoring it a bit I could reduce the runtime for 10,000 elements from 190 to 8 seconds. This is the original loop:...
I could also reduce `combine_sensor_data` from around ~600s to 37s (for 10,000 elements), without any major changes or parallelization. Should I open a draft PR with these changes, where we...
That would be great. Will open my promised PR tomorrow