IMSY-DKFZ
KWave adapter rotation bug fix
I switched rot90 to transpose transformation and deleted the reverse ordering of sensor elements in time series data.
So far not test have been run. It might make sense to implement additional tests for avoiding such bugs.
Please check the following before creating the pull request (PR):
- [x] Did you run automatic tests?
- [x] Did you run manual tests?
- [x] Is the code provided in the PR still backwards compatible to previous SIMPA versions?
List any specific code review questions
List any special testing requirements Please also test 3D case, this hasn't been done so far.
Additional context (e.g. papers, documentation, blog posts, ...)
Provide issue / feature request fixed by this PR
Fixes #264
Currently manual test simpa_tests/manual_tests/acoustic_forward_models/KWaveAcousticForwardConvenienceFunction.py fails, see #271. But this is likely not related to the changes from this PR, it already fails on develop.
simpa_tests/manual_tests/digital_device_twins/SimulationWithMSOTInvision.py also doesn't work but probably not related to this PR
There are still some rot90 left in simpa, mostly in the plotting functions and some tests (also in KWaveAcousticForwardConvenienceFunction, which is one reason why the output looks so strange). We should probably replace them too :D
There are still some rot90 left in simpa, mostly in the plotting functions and some tests (also in KWaveAcousticForwardConvenienceFunction, which is one reason why the output looks so strange). We should probably replace them too :D
You were right, the rot90 error was also a problem in the KWaveAcousticForwardConvenienceFunction test. Furthermore the field of view and the spacing needed to be set in order to have a visually similar reconstruction. Now #271 should also be fixed.