Franco Meloni
Franco Meloni
Hey @Nikoloutsos, thank you for putting this proposal together :) We already have something similar to allow you to modify the DangerDSL: Look for example this test file, where the...
This one is quite interesting, I think is more a danger-js bug, but the repo for that PR is null ``` "repo": null ```
It shouldn't, but if you run `danger pr https://github.com/danger/swift/pull/95 --json` you get it, also, another interesting thing: the repo inside `"pr"` is nil, but not the one inside `"base"` 🤔
> Legit - probably a deleted repo It totally makes sense, didn't think about it
When I did https://github.com/danger/danger-js/pull/940 my idea was exactly to extend Danger to all the PR related cases. I agree with Orta that status is not strictly a PR related event,...
It might be (just a guess) that before we were trying to post the comments one by one, so if one was failing, that was added to the Danger "global"...
that could not work given https://github.com/danger/danger-js/issues/958 :(
Yes, that would allow me to play also a little bit with the Danger config as well. At the moment I'm working on replacing Marathon on Danger-swift but as soon...
I was having a look at this issue, but from what I see in the Package.swift there are actually no dev dependencies or tests that Rocket should remove https://github.com/Moya/Moya/blob/master/Package.swift
Ok lol Makes a lot of sense :D Thank you 💯 You should see my draft PR soon then :P