evanshultz

Results 288 comments of evanshultz
trafficstars

Thanks! 1. You can remove line 42 for sure. 1. Other commented lines can be removed. 1. See the documentation for the related generator that is nearly ready at https://github.com/pointhi/kicad-footprint-generator/pull/380....

Oh. All dimensions in the YAML file are OK.

1. I don't like the use of `silk_pin1_marker_type` and `fab_pin1_marker_type` having numeric values that aren't descriptive. Can you change the values to something salient? If this is done in other...

@chschlue Can you please confirm that this repo won't be migrated? At least not yet? I merged the footprints but would like to get a few of these under-the-hood updates...

They both run for me and generate footprints. And they both have `import yaml` on line 26. In fact, the header section is identical in both files. This seems a...

@calebreister You've mentioned using JSON many times in many comments. While we have a lot to do with the GitLab migration and v6, but U haven't seen anybody comment. Personally,...

@matthijskooijman How did you come across this? I didn't take a close look yet, but I'd like to understand how you found this for perspective. Thank you.

@matthijskooijman Ah. Got it. Thank you. @poeschlr This is your code and it looks like a good fix. Can you take a look?

@poeschlr Thanks! Merging your commit produces a courtyard offset of 0.1mm on this footprint. Is that what you expect? ![image](https://user-images.githubusercontent.com/1936989/59061666-d3988b00-8858-11e9-9df4-74cd280ee2d8.png)