kicad-footprint-generator
kicad-footprint-generator copied to clipboard
pointhi
Add JST XA
used to be #484 created this pull request, as i had no permission to update the original request with my commits.
@fenugrec mind taking a look at my updates?
Code Climate has analyzed commit 1cf6b78d and detected 0 issues on this pull request.
View more on Code Climate.
![codeclimate[bot] avatar](https://avatars.githubusercontent.com/in/9403?v=4 "Published by a pub.dev verified publisher"){kind=small}
@fenugrec in case you're satisfied with them, it would be cool if you could also update https://github.com/KiCad/kicad-footprints/pull/2169
- I don't like the use of
silk_pin1_marker_typeandfab_pin1_marker_typehaving numeric values that aren't descriptive. Can you change the values to something salient? If this is done in other scripts then it's fine to leave it. - Please add
thtto the script file names since they don't do the SMT footprints. - Add explicit comments to anywhere I missed that show if a dimension not in the datasheet was measured from a real part, from the 3D model, or somewhere else.
- I made some comments on the horizontal script that also apply to the vertical one, but I didn't repeat them again. Please assume comments cover both orientations.
- If the 18 pin doesn't exist, at least as of today, you can simplify the vertical script. But that being said, you could also do something more quick and dirty since perhaps things are apt to change. Either way.
If you can make each change in a separate commit that might be easier to review.
@chschlue Can you please confirm that this repo won't be migrated? At least not yet? I merged the footprints but would like to get a few of these under-the-hood updates to the script before merging this.
