evanshultz

Results 288 comments of evanshultz
trafficstars

@cpresser What do you want to do with this? I quickly looked at just the changed file (not the new one) and I'm not thrilled with some variable names but...

I don't think pin 1 has to be the first pin as the entire footprint can be rotated as I mentioned above. I haven't tried this, but it looks from...

Looks OK to me once the style issues are addressed.

Everything here is under /scripts, so @pointhi should be fine with it. Can codeclimate be run again to check if there are any remaining style issues, or has it already...

1. Link to page 36 since that's the package drawing and our script doesn't follow the datasheet footprint. 2. I would prefer to see this in `kicad-footprint-generator/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/qfn/qfn_texas.yaml`, since TI has...

For consistency, I'd rather implement a `custom_name_format` keyword for YAML files like in our other generators. At least the SON one. That keyword and it's behavior, as implemented elsewhere, gives...

OK. I'm fine with another approach that works better for everyone. I can take a swing at that method in a bit. No problem. Is this holding anything up? I...

So #645 is the only issue we know of. @cpresser Go basically go back to the way it was before, but change line 228 (or add a line after it)...

Good idea! A few thoughts: - Could `/PadGenerator` go under `/general` or `/tool`? - Can both `/Connector*` and `/Multicomp` and `/pin-header*` folders go under the root `/Connector`? Maybe one of...

@poeschlr Can you respond to the first three bullets I mentioned above? Those seem straightforward enough to include now.