Evan Rittenhouse comments

Results 85 comments of


                                            Evan Rittenhouse

Git dependencies' submodules with relative URLs handled incorrectly (regression from 1.1)

Hey @neersighted, thanks for doing that - I see the submodule folder on the `relative_submodule` branch. Sorry for all the questions + appreciate the patience. I haven't worked much with...

Git dependencies' submodules with relative URLs handled incorrectly (regression from 1.1)

Apologies for the delay, work has been crazy. Commenting here so the issue doesn't get picked up by someone else as I'm basically code complete - will hopefully be able...

Debug level logging (-vvv) should report when a .gitignore file was used to ignore a potential package file

@dimbleby I've got a local branch with a `logger.debug` call to print out the ignored files. Should I submit the PR against Poetry or Poetry-Core?

Impossible to do literal order by with subQuery and minifyAliases enabled

@tomquist opening this draft PR so you can see progress. I may also ask you a few clarifying questions as I'm not super familiar with PostgreSQL, which is where `minifyAliases`...

Impossible to do literal order by with subQuery and minifyAliases enabled

@WikiRik can you please confirm that this fix will be included in the newest release? CC @tomquist

feat: add updateOnDuplicate to included models

Seems like error codes from the two failed jobs stem from DB2 and MSSQL not supporting `updateOnDuplicate`, which should be expected failures.

feat: add updateOnDuplicate to included models

@WikiRik Sure - where/how can I do that? Would it just be a check for `this.sequelize.dialect == 'db2'` in the test, or is it somewhere in the GitHub CI/CD pipeline?

feat: add updateOnDuplicate to included models

This is done and all tests are passing.

feat: add updateOnDuplicate to included models

@ephys To be honest, I'm not great with the type system. Would you be able to help resolve this issue?

Submodules are not checked out recursively

@finswimmer Sorry for the basic question, but how do I submit a PR for `poetry-core` changes when the issue is filed in `poetry`? Should I just replicate the issue in...