poetry icon indicating copy to clipboard operation
poetry copied to clipboard

Submodules are not checked out recursively

Open tomuben opened this issue 3 years ago • 3 comments

  • [x] I am on the latest Poetry version.
  • [x] I have searched the issues of this repo and believe that this is not a duplicate.
  • [x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: Ubuntu 20.04
  • Poetry version: 1.1.14
  • Link of a Gist with the contents of your pyproject.toml file: https://github.com/exasol/script-languages-release/tree/develop

Issue

My project contains a submodule. (Actually the pyproject.toml is in the submodule, but I think this does not matter). The clone works as expected, considering the submodule. However, the checkout for a specific branch, does not update the submodule: This line should be:

args += ["checkout", "--recurse-submodules", rev]

tomuben avatar Jul 19 '22 11:07 tomuben

Hello @tomuben,

thanks a lot for reporting. Your suggestion looks reasonable to me. I'm happy to review a PR ;)

fin swimmer

finswimmer avatar Jul 20 '22 16:07 finswimmer

@finswimmer Sorry for the basic question, but how do I submit a PR for poetry-core changes when the issue is filed in poetry? Should I just replicate the issue in poetry-core and then submit the PR against that repo? I have the code ready on my local.

evanrittenhouse avatar Aug 05 '22 16:08 evanrittenhouse

We don't track poetry-core issues separately. Just submit the PR and link this issue (python-poetry/poetry#6033). See also other poetry-core PRs for example.

radoering avatar Aug 08 '22 04:08 radoering

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

github-actions[bot] avatar Mar 01 '24 14:03 github-actions[bot]